Resolve the second-pass review findings — comments undo via .trash recursion, search reach, refuse-don't-degrade paste
Thirteen findings cleared with the user (Redesign board: 3 Contradictions + 3 Gaps + 7 Minors → Resolved): - User template store re-homes to the shared App Group container (09/02) — templates cross editions; App Group implementation card annotated mid-flight. - Comment delete = move into comments/.trash/ (01/05/13) — the materialized-trash pattern one level down; no byte capture returns on any edition; purge at window close, copies strip it; 13's absolutes stay true. - Find & search: card-window ⌘F covers the focused comments pane; board search re-ruled to all meaningful card content — comment bodies via a search-owned transient index when comments ship, attributes as they activate (04/01/05); scope options = WISHLIST #10. - Comments pane visibility = one persisted app-wide bit, à la Show Trash — content-derived auto-show retired (05/11). - Comment attachments author in-window: composer/inline-edit drop carve-outs + paperclip (05). - Item-level copies sever remote/remote-state at every level; whole-board forks exempt (01). - Paste refuses loudly, never degrades — degraded embedded-index.md fallback and its loss row retired; Finder's whole-or-nothing invariant adopted (04/12/02). - Escape: composer moves focus out (never discards a draft); inline comment edit = Cancel (05/11). - Minors: 05 three-pane changes bullet, 01 comments-UI parenthetical, 07 TOFU store naming, WISHLIST item 3 trash wording, README deferred-list now points at the findings board. Claude-Session: https://claude.ai/code/session_01CqjXB7ASoWtbyoGod68k97
This commit is contained in:
@@ -29,7 +29,7 @@ The single source of truth for **every command and action the app can perform**
|
||||
| File | Save as Template | — (no default) | Board window; 09-templates.md |
|
||||
| File | Reveal in Finder | — (no default) | Board window: the selection's folder(s), or the board root with nothing selected; card window: the card's folder — the selected attachment's file instead when the attachments section is focused; welcome: the selected recent's folder (disabled on unavailable rows) — the context-menu entry's required twin |
|
||||
| File | Add Attachment… | ⇧⌘A | Card window |
|
||||
| File | Add Comment | — (no default) | Card window (all editions — 12); reveals the comments column if hidden and focuses the composer — 05 ▸ The comments column |
|
||||
| File | Add Comment | — (no default) | Card window (all editions — 12); if Show Comments is off, turns it on (persisted, the same user choice) and focuses the composer — 05 ▸ The comments column |
|
||||
| File | Delete | ⌘⌫ | Board window, any card or lane selection — staged by place (resettled 2026-07-28; lanes rejoined 2026-07-29): board cards and lanes move to `.trash/`, trash selections delete permanently (03's recoverability confirm — freight-counting for lanes). Deliberately **not** extended to the card window: an enabled ⌘⌫ key equivalent would steal delete-to-line-start from the window's text surfaces, so there the card's delete is the sidebar Actions button (05) |
|
||||
| File | Delete Immediately | ⌥⌘⌫ | Board window, any card or lane selection — skips the trash from anywhere; confirmed on boards without git history (mode none / repo-nested), immediate on git boards — 03 ▸ Trash |
|
||||
| File | Empty Trash… (confirmed) | ⇧⌘⌫ | Board window, trash shown and non-empty (whole-trash scope, search-independent — 03 ▸ Trash) |
|
||||
@@ -48,7 +48,7 @@ The single source of truth for **every command and action the app can perform**
|
||||
| Board | Pull / Push | — (no default) | Remote-backed boards only (07); disabled during 06's abnormal-state pause (the whole git surface holds) and on an unresolvable remote (07's one-time remote picker case); popover twins exist |
|
||||
| View | Show Trash (checkmark toggle) | — (no default) | Board window — ⇧⌘T is deliberately left to the system's Show Tab Bar: window tabbing stays enabled (settled; see Standard macOS furniture), so the chord is the system's; assign one via the remapping mechanism if wanted (04 ▸ Configurable bindings) |
|
||||
| View | Edit Body (checkmark toggle) | ⌘E | Card window; disabled while Raw Source is active |
|
||||
| View | Show Comments (checkmark toggle) | — (no default) | Card window; per-window, transient — the column auto-shows when the thread is non-empty (05 ▸ The comments column) |
|
||||
| View | Show Comments (checkmark toggle) | — (no default) | Card window; app-wide, persisted across restarts (re-ruled 2026-07-29 — no content-derived auto-show; 05 ▸ The comments column) |
|
||||
| View | Comments Beside Body (checkmark toggle) | — (no default) | Card window; checked = side-by-side (default), unchecked = body over comments; app-wide, persisted (05 ▸ Composition) |
|
||||
| View | Raw Source (checkmark toggle; toggling off = Apply) | ⌥⌘E | Card window |
|
||||
| View | History | — (no default) | Card window; focuses the sidebar History section (05); git boards only — section absent, item disabled on mode none / repo-nested |
|
||||
@@ -70,6 +70,8 @@ All board grammar keys are inert while a title editor is focused, and menu dispa
|
||||
| Escape | Card window, Edit | Return to Preview |
|
||||
| Return | Card window, title field | Commit title, focus into body |
|
||||
| ⌘↩ | Card window, comment composer or inline comment editor focused | Post the draft (rename + restamp, one commit) / end the edit session at its commit point — 05 ▸ The comments column; twinned by the Comment / Save buttons |
|
||||
| Escape | Card window, comment composer focused | Focus moves out, draft file untouched — Escape never discards a draft (ruled 2026-07-29; 05 ▸ The comments column) |
|
||||
| Escape | Card window, inline comment editor focused | Cancel — revert to session-start bytes and end the session, the Cancel button's keyboard twin (05) |
|
||||
| Escape | Card window, title field | Abandon: revert to the on-disk title, focus into body — routes by focus, winning over Edit-mode's Escape while the field is focused (05) |
|
||||
| Escape / ⌘↩ | Card window, source mode | Cancel / Apply (leaving-by-toggle is Apply too — 05) |
|
||||
| Arrows / Space / Return / ⌫ | Card window, attachments section focused | Row navigation / QuickLook / open / Remove to *system* Trash (05) |
|
||||
|
||||
Reference in New Issue
Block a user