Materialize the trash — faces, menus, and grammar
Phase 3 finishes the pivot at the surface. One card face serves two containers: CardFaceView extracted with a role — board or trash — so stripe, tint, chip, selection stroke, cut dim, marquee registration, and drag are shared by construction, the trash side differing only in its absences: no Open, no rename, no Style, no file-hover highlight, and a Delete that goes through the confirmation host. The column rewrote around the lanes' own single-column masonry so drag reflow reads as positional slides; chrome stays the hatched header, symbol, and count — 11 gives Empty Trash to the File menu alone. Two real grammar bugs die here: plain Backspace on a trash selection purged without the confirmation the menu raises, and the context menu's Delete resolved against the standing selection, so right-clicking a trash card under a board selection silently did nothing — it now stages the clicked set explicitly. Open, Rename, Style, and Empty Trash validation became testable store seams; the column is one named accessibility container of ordinary card elements. The tombstone era is swept: deleteItem, restoreItem, stripTombstonedChildren — dead since lane copies stopped nesting trash — the restore verb, the unreachable put-back banner row, and every quasi-lane doc comment. Claude-Session: https://claude.ai/code/session_01SR4XGjmBE16ZUYWpfFHXwY
This commit is contained in:
@@ -47,7 +47,6 @@ private let everyOperation: [WriteOperation] = [
|
||||
.reorder(title: "Fix login"),
|
||||
.copy(title: "Fix login"),
|
||||
.delete(title: "Fix login"),
|
||||
.restore(title: "Fix login"),
|
||||
.purge(title: "Fix login"),
|
||||
.style(title: "Fix login"),
|
||||
.resize(title: "Fix login"),
|
||||
@@ -63,7 +62,6 @@ private let titledOperations: [(with: WriteOperation, without: WriteOperation)]
|
||||
(.reorder(title: "Fix login"), .reorder(title: nil)),
|
||||
(.copy(title: "Fix login"), .copy(title: nil)),
|
||||
(.delete(title: "Fix login"), .delete(title: nil)),
|
||||
(.restore(title: "Fix login"), .restore(title: nil)),
|
||||
(.purge(title: "Fix login"), .purge(title: nil)),
|
||||
(.style(title: "Fix login"), .style(title: nil)),
|
||||
(.resize(title: "Fix login"), .resize(title: nil)),
|
||||
@@ -488,15 +486,13 @@ struct BannerCenterPhrasingTests {
|
||||
!= BannerCenter.headline(for: error(.style(title: "Fix login"))))
|
||||
}
|
||||
|
||||
@Test("The trash trio speaks the board's vocabulary, never the system Trash's")
|
||||
@Test("The trash verbs speak the board's vocabulary, never the system Trash's")
|
||||
func trashVerbsFollowTheNamingConstraint() {
|
||||
// 03-board-ui.md § Trash's naming constraint, settled with the trash UI copy: two "Trash"
|
||||
// concepts coexist, and "Finder's 'Move to Trash' phrasing is reserved for the system Trash;
|
||||
// board deletion says 'Delete'". A banner is UI copy like any other.
|
||||
#expect(BannerCenter.headline(for: error(.delete(title: "Fix login"), .io(message: "the disk is full")))
|
||||
== "Couldn't delete 'Fix login' — the disk is full")
|
||||
#expect(BannerCenter.headline(for: error(.restore(title: "Fix login"), .io(message: "the disk is full")))
|
||||
== "Couldn't put 'Fix login' back — the disk is full")
|
||||
#expect(BannerCenter.headline(for: error(.purge(title: "Fix login"), .io(message: "the disk is full")))
|
||||
== "Couldn't permanently delete 'Fix login' — the disk is full")
|
||||
|
||||
|
||||
Reference in New Issue
Block a user