3 Commits

Include renames

Author	SHA1	Message	Date
rzen	8345378972	The board settings sheet — setup leaves the popover for a home a stray click can't dismiss ... The popover/sheet split lands: a board-scoped, titled, sectioned sheet on the board window hosts everything setup-shaped, opened from the popover's Board Settings… row and the new Board ▸ Board Settings… menu row. The three existing setup controls relocate — add-git (whose noteFormVisible lines now make the sheet the form-anchored failure surface), branch creation (a standing field; create-and-switch runs the identical settle sequence), and the commit-identity fields (the 2s visibility-scoped poll rides with them). The popover keeps the daily face and its postures; its Pro/mode-none section becomes header + door (.addGit renamed .noRepository). Availability is derived from the section inventory (Pro + mode none or git), so pro-m2's sections can't drift from the doors; the sheet's fields join the caret-chord disable set. The audit suite pins what the free fixture can reach; the sheet's own audit is manual until a tier override is ruled. Claude-Session: https://claude.ai/code/session_01CqjXB7ASoWtbyoGod68k97	2026-08-01 12:07:12 -04:00
rzen	274ccd9ff5	Realign code with the 2026-07-31 findings-resolution rulings ... The full bullet list from Implementation card bf080d9a — both ruling batches, including the three appended mid-session by 16ef377: - Restore subjects compose the inverse, never nest: crossing "Undo: S" emits "Redo: S" and vice versa; parity, not stack depth, reads a legacy double prefix (GitHistoryProvider.restoreSubject). - Git-operation failures join the one-shot failure banner tier: BannerCenter.GitFailureBanner (undo/redo/branchSwitch/addGit), error tone at failure rank merged with write one-shots by recency; the postLoss compromise is retired at both AppModel wirings. - order/schema optional below the board root: append-at-end reading (ordered siblings first, folder-name tie-break among the order-less), schema reads 1, both coerce-tier logged; the root keeps its requirements. Ranks.resolvedOrders materializes finite ranks so models and placement math stay untouched; first Writer rewrite stamps a real rank on touch, placement against an order-less sibling stamps that sibling inline in the same bracket. Agent guide v10 teaches optional keys and zero-read filing. Hostile-YAML order shapes become coercion tests; Fixtures/Valid/optional-keys.kanban replaces the four retired Malformed boards. - .gitignore is the relocation-heal noise gate: GitignoreRules pure matcher (standard semantics, board-root file only), loader consults it once per walk so matched loose files keep the stray posture; seeded (.DS_Store + .*.lanework-*) at board creation and template instantiation, healed in when missing at open — repo-nested included; empty file honored, existing files never edited; the committer's obedience via libgit2 status is pinned by test. - Comments crash-residue sweep gates on step ownership: HistoryStep derives backing from its own undo expectations, backedContent unions both stacks, the sweep purges per-entry only what no live step owns. - Skip-purge decoupled (16ef377): a stale-skipped coarse step strands whole in NativeHistoryProvider.strandedSteps — still backing, retired only at session end; clean exits purge as before. - Coarse close step named "Changes to '<card>'"; the fine body-edit wording never leaks onto the board menu. - Branch-switch settle clears every open card window's fine stack on Save All and Discard alike; the empty fold registers no coarse step. - Close flush awaits its covering snapshot (quiesce + one generation bump, 1s bound), and an explicit flush now queues behind an in-flight one instead of skipping — the audit-caught interleaving could lose a close flush permanently when the debounce fired inside the close sequence; regression tests force both races. - Commit comment bullets sort chronologically by created, not UUID. - The production-unwired CardBodyEditSession.editSessionDidChange seam is deleted with its seam-only tests. - Composition-root pins: beginSession composes the committer with the store's own EchoLedger and binds the announcer (the miswire class). - Deliberate 06 conformance pass over every 2026-07-31-tagged sentence: fixed Change-custom-key subjects (the retired named generic was the only producer), the unbuilt Replace attachment vocabulary, heal commits now authored Lanework Integrity, the config reader scopes identity to plain [user] sections, add-git re-runs detection at create (a stale mode-none could initialize inside the user's repo), and add-git failures answer at the form or the banner. Structural residue filed on the Redesign board. 2554 tests / 439 suites green. Claude-Session: https://claude.ai/code/session_01CqjXB7ASoWtbyoGod68k97	2026-08-01 07:43:45 -04:00
rzen	1f7d84bf64	Build branch switching and the popover git surface ... GitBranchSwitcher holds 06's sequence as one object: settle editors explicitly (SessionSettleGate — Save All applies raw buffers with validation and a refused buffer cancels the whole switch; Discard reverts buffers AND reconciles the session folders against HEAD; never silent), flush the pending auto-commit, stamp intent in the per-board registry, bracketed safe checkout (git_checkout_tree GIT_CHECKOUT_SAFE + set_head — no path passes FORCE, abort included), one reload via the async wholesale bracket (failed final reload engages the existing read-only lock), reseed undo/redo from the new HEAD with redo empty, clear the stamp. Create-and-switch keeps the full sequence — the tree-cannot-change proof fails under concurrent writers. Lock contention shows the 02 in-progress row's waiting state ("waiting for another writer's git lock"), bounded at 30s then failing cleanly naming the lock path. GitOperationStamp + GitOperationRecovery: the own-leftovers rule as a pure conjunction — pause state AND matching stamp = the app's own interrupted operation, aborted to the pre-operation state with a banner, stamp cleared on success only; either alone defers to the pause-and-defer stance. Checked where the committer starts. BoardGitControls replaces the read-only branch line: branch picker, inline create-and-switch, the abnormal-state pause note in 06's own words with controls dimmed, and commit-identity fields that read and write repo-local .git/config (derived default as placeholder, never value; unfocused resync, focused keystrokes kept; 2s poll while visible — .git is watcher-filtered by design). Also fixes a shipped bug from the undo card: plan(reconciling:) matched card ids as path prefixes, so the reconcile branch was inert on every board (<lane>/<card> never matches a bare id) — a session file the restore diff couldn't name (attachment, comment, draft) survived Discard and landed in the next flush's commit. One shared component-exact folder-name resolver now serves both Discard paths; noteDiscarded takes cardFolderName; regression test verified failing against the pre-fix code. 41 branch tests + the regression; 2374 tests / 409 suites green; InertGitTests untouched. Claude-Session: https://claude.ai/code/session_01SR4XGjmBE16ZUYWpfFHXwY	2026-07-31 16:41:14 -04:00