From 7dce2aeea63c430eebd27399428ac4ec2806f5c1 Mon Sep 17 00:00:00 2001 From: rzen Date: Sun, 5 Jul 2026 08:06:33 -0400 Subject: [PATCH] Repoint build stamping at the app-versioning skill's script Replaces the repo-local Scripts/update_build_number.sh (which git-tagged on every build) with the shared update_build_info.sh referenced in place from indie-skills: same commit-count CFBundleVersion and BuildDate, adds BuildHash, and makes release tagging opt-in via RELEASE_TAGGING=1. Verified BuildDate/BuildHash/CFBundleVersion land in the built app. --- CLAUDE.md | 2 +- Scripts/update_build_number.sh | 35 ---------------------------------- project.yml | 8 ++++---- 3 files changed, 5 insertions(+), 40 deletions(-) delete mode 100755 Scripts/update_build_number.sh diff --git a/CLAUDE.md b/CLAUDE.md index 32b6207..c0c713d 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -57,7 +57,7 @@ All in `Shared/Model/`: ### Platforms, Tooling & Entitlements - iOS 26 / watchOS 26; Swift 6 with `SWIFT_STRICT_CONCURRENCY: complete` on both targets. -- Build number is set from the git commit count by `Scripts/update_build_number.sh` (a post-build phase); `Scripts/` also holds the App Store / TestFlight release pipeline. +- Build number (git commit count), `BuildDate`, and `BuildHash` are stamped by the `app-versioning` skill's `update_build_info.sh` (referenced in place from `../indie-skills`, a post-build phase; release tagging is opt-in via `RELEASE_TAGGING=1`). `Scripts/` holds the App Store / TestFlight release pipeline. - Entitlements: iOS uses CloudDocuments + HealthKit; watch uses HealthKit only. **No CloudKit service, no App Group.** - SPM packages: `IndieSync` (file-side iCloud sync core), `IndieAbout` (in-app About / changelog / license UI), and `Yams` (YAML parsing). diff --git a/Scripts/update_build_number.sh b/Scripts/update_build_number.sh deleted file mode 100755 index 00c4b12..0000000 --- a/Scripts/update_build_number.sh +++ /dev/null @@ -1,35 +0,0 @@ -#!/bin/sh - -## IMPORTANT ## -# Add the following files to Input Files configuraiton of the build phase -# $(TARGET_BUILD_DIR)/$(INFOPLIST_PATH) -# $(DWARF_DSYM_FOLDER_PATH)/$(DWARF_DSYM_FILE_NAME)/Contents/Info.plist - -git=$(sh /etc/profile; which git) -number_of_commits=$("$git" rev-list HEAD --count) -git_release_version=$("$git" describe --tags --always --abbrev=0) - -target_plist="$TARGET_BUILD_DIR/$INFOPLIST_PATH" -dsym_plist="$DWARF_DSYM_FOLDER_PATH/$DWARF_DSYM_FILE_NAME/Contents/Info.plist" - -git_commit=`"$git" rev-parse --short HEAD` -bundle_version=`/usr/libexec/PlistBuddy -c "Print :CFBundleShortVersionString" "$target_plist"` -build_date=`date +%F` - -build="v$bundle_version-$git_commit b$number_of_commits $build_date" - -#echo "version=$bundle_version-$git_commit build $number_of_commits" - -"$git" tag "$bundle_version" - -for plist in "$target_plist" "$dsym_plist"; do - if [ -f "$plist" ]; then - /usr/libexec/PlistBuddy -c "Set :CFBundleVersion $number_of_commits" "$plist" -# /usr/libexec/PlistBuddy -c "Set :CFBundleShortVersionString ${version}" "$plist" -# /usr/libexec/PlistBuddy -c "Set :CFBundleShortVersionString ${git_release_version#*v}" "$plist" - - # Add build date for AppInfoKit - /usr/libexec/PlistBuddy -c "Set :BuildDate $build_date" "$plist" 2>/dev/null || \ - /usr/libexec/PlistBuddy -c "Add :BuildDate string $build_date" "$plist" - fi -done diff --git a/project.yml b/project.yml index b70441c..86a8de4 100644 --- a/project.yml +++ b/project.yml @@ -52,8 +52,8 @@ targets: - package: Yams - target: Workouts Watch App postBuildScripts: - - script: '"${SRCROOT}/Scripts/update_build_number.sh"' - name: Update Build Number + - script: '"${SRCROOT}/../indie-skills/skills/app-versioning/scripts/update_build_info.sh"' + name: Update Build Info shell: /bin/sh basedOnDependencyAnalysis: false inputFiles: @@ -89,8 +89,8 @@ targets: - target: Workouts Watch Widget embed: true postBuildScripts: - - script: '"${SRCROOT}/Scripts/update_build_number.sh"' - name: Update Build Number + - script: '"${SRCROOT}/../indie-skills/skills/app-versioning/scripts/update_build_info.sh"' + name: Update Build Info shell: /bin/sh basedOnDependencyAnalysis: false inputFiles: