Files
workouts/WorkoutsTests/DuplicateCleanupPlannerTests.swift
T
rzen 394ec0989e Record per-set actuals and drive the chart and volume from them
Every completed set now writes a SetEntry (reps/weight or seconds),
pre-filled from the plan by transition(to:) so the list checkbox, both
run flows, and One More all capture for free; reset clears, skip keeps
partials. The rest and finish pages show the just-done set as a pill
that opens a stepper sheet for correcting reps and weight (2.5 lb /
1.25 kg steps). The Weight Progression chart plots the top-set actual
weight and workout volume sums recorded sets, both falling back to the
plan for legacy logs via effectiveSetEntries.

Storage side of UX #3 rides along: plan weights are Double now.
Schema bumps: SplitDocument 2→3, WorkoutDocument 3→4 (a fractional
weight fails an older Int decode, and a rewrite would strip the
irreplaceable actuals), SwiftData cache 4→5. A per-log updatedAt is
reserved for the future cross-device log merge.

Claude-Session: https://claude.ai/code/session_01HJDQQDA9QdP8zByg43H5v3
2026-07-08 12:48:37 -04:00

199 lines
9.0 KiB
Swift

import Foundation
import Testing
@testable import Workouts
/// Locks the survivor rules of `DuplicateCleanupPlanner` — the safety-critical
/// part of the developer duplicate-cleanup tool. Referenced-split and seed
/// protection must always beat "earliest ULID wins," an in-progress workout must
/// never be touched, and the HealthKit-link holder must always survive (deleting
/// it would cascade-delete the real Health sample). Fixed 26-char ULID-like ids
/// keep every assertion deterministic.
struct DuplicateCleanupPlannerTests {
// MARK: - Fixtures
private func id(_ n: Int) -> String {
"01TESTID" + String(repeating: "0", count: 16) + String(format: "%02d", n)
}
private func exercise(
name: String = "Bench Press", order: Int = 0, sets: Int = 3, reps: Int = 10,
weight: Double = 100, loadType: Int = LoadType.weight.rawValue, duration: Int = 0
) -> ExerciseDocument {
ExerciseDocument(
id: "EX-\(name)-\(order)", name: name, order: order, sets: sets, reps: reps, weight: weight,
loadType: loadType, durationSeconds: duration
)
}
private func split(
id splitID: String, name: String = "Push Day", exercises: [ExerciseDocument]? = nil,
createdAt: Date = Date(timeIntervalSince1970: 0)
) -> SplitDocument {
SplitDocument(
schemaVersion: SplitDocument.currentSchemaVersion, id: splitID, name: name, color: "indigo",
systemImage: "dumbbell.fill", order: 0, createdAt: createdAt, updatedAt: createdAt,
exercises: exercises ?? [exercise()], activityType: nil
)
}
private func log(name: String = "Bench Press", order: Int = 0, date: Date = Date(timeIntervalSince1970: 0)) -> WorkoutLogDocument {
WorkoutLogDocument(
id: "LOG-\(name)-\(order)", exerciseName: name, order: order, sets: 3, reps: 10, weight: 100,
loadType: LoadType.weight.rawValue, durationSeconds: 0, currentStateIndex: 0,
status: WorkoutStatus.completed.rawValue, notes: nil, date: date
)
}
private func workout(
id workoutID: String, splitID: String? = "SPLIT-1", splitName: String? = "Push Day",
start: Date, status: String = WorkoutStatus.completed.rawValue,
logs: [WorkoutLogDocument]? = nil, metrics: WorkoutMetrics? = nil
) -> WorkoutDocument {
WorkoutDocument(
schemaVersion: WorkoutDocument.currentSchemaVersion, id: workoutID, splitID: splitID,
splitName: splitName, start: start, end: nil, status: status, createdAt: start, updatedAt: start,
logs: logs ?? [log(date: start)], metrics: metrics
)
}
/// A fixed calendar day/time built via `Calendar.current`, so it agrees with
/// the planner's own `Calendar.current`-based day bucketing regardless of the
/// test runner's time zone.
private func fixedDate(day: Int = 15, hour: Int = 9) -> Date {
var comps = DateComponents()
comps.year = 2024
comps.month = 3
comps.day = day
comps.hour = hour
return Calendar.current.date(from: comps)!
}
private func metrics(healthKitWorkoutUUID: String? = nil, recordedAt: Date = Date(timeIntervalSince1970: 0)) -> WorkoutMetrics {
WorkoutMetrics(
activeEnergyKcal: nil, avgHeartRate: nil, maxHeartRate: nil, minHeartRate: nil,
totalVolume: nil, hrZoneSeconds: nil, healthKitWorkoutUUID: healthKitWorkoutUUID,
source: .watch, recordedAt: recordedAt
)
}
// MARK: - Split survivor rules
@Test func identicalUnreferencedSplitsKeepEarliestULID() {
let earlier = split(id: id(1))
let later = split(id: id(2))
let plan = DuplicateCleanupPlanner.plan(
splits: [later, earlier], workouts: [], referencedSplitIDs: [], isSeed: { _ in false }
)
#expect(plan.splitGroups.count == 1)
#expect(plan.splitGroups[0].keep.map(\.id) == [id(1)])
#expect(plan.splitGroups[0].delete.map(\.id) == [id(2)])
}
/// Referenced-protection must override "earliest ULID wins": a later,
/// referenced split survives and the earlier, unreferenced duplicate is the
/// one deleted — the opposite of the no-protection tiebreak.
@Test func referencedProtectionOverridesEarliestWins() {
let earlier = split(id: id(1)) // unreferenced, would win the earliest-id tiebreak alone
let later = split(id: id(2)) // referenced by a workout
let plan = DuplicateCleanupPlanner.plan(
splits: [earlier, later], workouts: [], referencedSplitIDs: [id(2)], isSeed: { _ in false }
)
#expect(plan.splitGroups.count == 1)
#expect(plan.splitGroups[0].keep.map(\.id) == [id(2)])
#expect(plan.splitGroups[0].delete.map(\.id) == [id(1)])
}
@Test func seedMemberNeverDeleted() throws {
let seedSplit = split(id: id(1))
let duplicate = split(id: id(2))
let plan = DuplicateCleanupPlanner.plan(
splits: [seedSplit, duplicate], workouts: [], referencedSplitIDs: [],
isSeed: { $0 == id(1) }
)
let group = try #require(plan.splitGroups.first)
#expect(group.keep.map(\.id) == [id(1)])
#expect(group.delete.map(\.id) == [id(2)])
#expect(!group.delete.contains { $0.id == id(1) })
}
@Test func differingExerciseContentNotGrouped() {
let a = split(id: id(1), exercises: [exercise(weight: 100)])
let b = split(id: id(2), exercises: [exercise(weight: 105)])
let plan = DuplicateCleanupPlanner.plan(
splits: [a, b], workouts: [], referencedSplitIDs: [], isSeed: { _ in false }
)
#expect(plan.splitGroups.isEmpty)
}
/// Machine comfort settings are real content: splits identical except for a
/// setting value — or for the nil (non-machine) vs. empty (machine, nothing
/// recorded) distinction — must not be judged duplicates.
@Test func differingMachineSettingsNotGrouped() {
var lowSeat = exercise()
lowSeat.machineSettings = [MachineSetting(name: "Seat Height", value: "4")]
var highSeat = exercise()
highSeat.machineSettings = [MachineSetting(name: "Seat Height", value: "5")]
var machineNothingRecorded = exercise()
machineNothingRecorded.machineSettings = []
let a = split(id: id(1), exercises: [lowSeat])
let b = split(id: id(2), exercises: [highSeat])
let c = split(id: id(3), exercises: [machineNothingRecorded])
let d = split(id: id(4)) // machineSettings nil — not a machine exercise
let plan = DuplicateCleanupPlanner.plan(
splits: [a, b, c, d], workouts: [], referencedSplitIDs: [], isSeed: { _ in false }
)
#expect(plan.splitGroups.isEmpty)
}
// MARK: - Workout grouping / survivor rules
@Test func sameDayWorkoutsDifferingOnlyInIDsAndTimestampsAreGrouped() {
let day = fixedDate(hour: 9)
let sameDayLater = fixedDate(hour: 20)
let w1 = workout(id: id(1), start: day)
let w2 = workout(id: id(2), start: sameDayLater)
let plan = DuplicateCleanupPlanner.plan(
splits: [], workouts: [w1, w2], referencedSplitIDs: [], isSeed: { _ in false }
)
#expect(plan.workoutGroups.count == 1)
#expect(plan.workoutGroups[0].keep.id == id(1))
#expect(plan.workoutGroups[0].delete.map(\.id) == [id(2)])
}
@Test func differentDaysNotGrouped() {
let w1 = workout(id: id(1), start: fixedDate(day: 15))
let w2 = workout(id: id(2), start: fixedDate(day: 16))
let plan = DuplicateCleanupPlanner.plan(
splits: [], workouts: [w1, w2], referencedSplitIDs: [], isSeed: { _ in false }
)
#expect(plan.workoutGroups.isEmpty)
}
@Test func inProgressMemberDropsEntireGroup() {
let start = fixedDate()
let w1 = workout(id: id(1), start: start, status: WorkoutStatus.inProgress.rawValue)
let w2 = workout(id: id(2), start: start, status: WorkoutStatus.inProgress.rawValue)
let plan = DuplicateCleanupPlanner.plan(
splits: [], workouts: [w1, w2], referencedSplitIDs: [], isSeed: { _ in false }
)
#expect(plan.workoutGroups.isEmpty)
}
/// The HealthKit-link holder must survive even though the other copy has the
/// lexicographically smaller (earlier) id — deleting the link holder would
/// cascade-delete the real Health sample.
@Test func healthKitLinkHolderSurvivesOverEarlierULID() throws {
let start = fixedDate()
let earlierNoLink = workout(id: id(1), start: start, metrics: nil)
let laterWithLink = workout(id: id(2), start: start, metrics: metrics(healthKitWorkoutUUID: "HK-UUID"))
let plan = DuplicateCleanupPlanner.plan(
splits: [], workouts: [earlierNoLink, laterWithLink], referencedSplitIDs: [], isSeed: { _ in false }
)
let group = try #require(plan.workoutGroups.first)
#expect(group.keep.id == id(2))
#expect(group.delete.map(\.id) == [id(1)])
}
}