rzen
274ccd9ff5
The full bullet list from Implementation card bf080d9a — both ruling batches, including the three appended mid-session by16ef377: - Restore subjects compose the inverse, never nest: crossing "Undo: S" emits "Redo: S" and vice versa; parity, not stack depth, reads a legacy double prefix (GitHistoryProvider.restoreSubject). - Git-operation failures join the one-shot failure banner tier: BannerCenter.GitFailureBanner (undo/redo/branchSwitch/addGit), error tone at failure rank merged with write one-shots by recency; the postLoss compromise is retired at both AppModel wirings. - order/schema optional below the board root: append-at-end reading (ordered siblings first, folder-name tie-break among the order-less), schema reads 1, both coerce-tier logged; the root keeps its requirements. Ranks.resolvedOrders materializes finite ranks so models and placement math stay untouched; first Writer rewrite stamps a real rank on touch, placement against an order-less sibling stamps that sibling inline in the same bracket. Agent guide v10 teaches optional keys and zero-read filing. Hostile-YAML order shapes become coercion tests; Fixtures/Valid/optional-keys.kanban replaces the four retired Malformed boards. - .gitignore is the relocation-heal noise gate: GitignoreRules pure matcher (standard semantics, board-root file only), loader consults it once per walk so matched loose files keep the stray posture; seeded (.DS_Store + .*.lanework-*) at board creation and template instantiation, healed in when missing at open — repo-nested included; empty file honored, existing files never edited; the committer's obedience via libgit2 status is pinned by test. - Comments crash-residue sweep gates on step ownership: HistoryStep derives backing from its own undo expectations, backedContent unions both stacks, the sweep purges per-entry only what no live step owns. - Skip-purge decoupled (16ef377): a stale-skipped coarse step strands whole in NativeHistoryProvider.strandedSteps — still backing, retired only at session end; clean exits purge as before. - Coarse close step named "Changes to '<card>'"; the fine body-edit wording never leaks onto the board menu. - Branch-switch settle clears every open card window's fine stack on Save All and Discard alike; the empty fold registers no coarse step. - Close flush awaits its covering snapshot (quiesce + one generation bump, 1s bound), and an explicit flush now queues behind an in-flight one instead of skipping — the audit-caught interleaving could lose a close flush permanently when the debounce fired inside the close sequence; regression tests force both races. - Commit comment bullets sort chronologically by created, not UUID. - The production-unwired CardBodyEditSession.editSessionDidChange seam is deleted with its seam-only tests. - Composition-root pins: beginSession composes the committer with the store's own EchoLedger and binds the announcer (the miswire class). - Deliberate 06 conformance pass over every 2026-07-31-tagged sentence: fixed Change-custom-key subjects (the retired named generic was the only producer), the unbuilt Replace attachment vocabulary, heal commits now authored Lanework Integrity, the config reader scopes identity to plain [user] sections, add-git re-runs detection at create (a stale mode-none could initialize inside the user's repo), and add-git failures answer at the form or the banner. Structural residue filed on the Redesign board. 2554 tests / 439 suites green. Claude-Session: https://claude.ai/code/session_01CqjXB7ASoWtbyoGod68k97
5.4 KiB
5.4 KiB
Fixture boards
Golden fixture boards for the storage-contract test suite — real on-disk folder trees, not inline strings, so the same fixtures can later drive XCUITests via the --open-board launch hook.
Bundled into the unit-test target as a folder reference (see project.yml). Valid boards live under Valid/, fail-fast cases under Malformed/. Tests live in KanbanTests/FixtureBoardTests.swift.
Hidden fixture files are named .hidden-* rather than .DS_Store: the repo's .gitignore ignores .DS_Store everywhere, so a fixture spelled that way would exist on the authoring machine and vanish from a fresh clone. The loader's rule is .skipsHiddenFiles — it is about the leading dot, not the name.
Lane/card folder names are fixed literal lowercase-UUIDv4-shaped strings (never generated at test time), chosen so their lexicographic order matches the expected tie-break order — usually a leading digit (10000000-..., 20000000-..., …) so folder order reads the same as array-index order in the tests. That is a fixture-authoring convention, not the loader's gate: the identity predicate is shape-only (8-4-4-4-12 hex, any case, any version — 01-storage-format.md § Fractal layout ▸ Rules), and the case/version coverage lives in KanbanTests/BoardLoaderTests.swift rather than here.
Valid/ — one board per tolerated/valid case
| Board | Case |
|---|---|
rich-board.kanban |
A full-breadth well-formed board: 2 lanes, 3 cards, bodies, styling (background/icon/iconColor/width), unknown + reserved frontmatter keys, attachments/ and comments/ with real content. Its attachments/ also carries all four listing shapes — two ordinary files, a hidden one, and a subfolder with a file — so Card.attachments' flat rule (01-storage-format.md § Attachments) is asserted against a real tree. Also the board every index.md in the tree is round-tripped against. |
interrupted-create.kanban |
The motivating skip-not-error case: a UUID-shaped lane folder and a UUID-shaped card folder, each with no index.md yet (folder created, write not yet landed). |
non-uuid-strays.kanban |
Non-UUID-shaped folders at both lane and card depth, with and without index.md — name shape gates candidacy before the file is ever read. |
stray-files.kanban |
Stray (non-directory) files at board, lane, and card level — never level candidates, never warned about. The card-level one (scratch.md) is also the loose-file carve-out's golden case: tolerated everywhere else, it is reported in LoadResult.looseCardFiles for the app to relocate into attachments/ (01-storage-format.md § Fractal layout ▸ Rules, settled 2026-07-28). Detection is read-only, so the file stays put on disk. |
tombstones.kanban |
A tombstoned lane and a tombstoned card, both still on disk and still in the snapshot, flagged (isDeleted) rather than removed. Also proves a tombstoned lane doesn't recursively flag its own un-deleted children. |
duplicate-order-tie-break.kanban |
Three cards sharing one order in one lane, and two lanes sharing one order — both broken by folder name, ascending. |
unknown-key-order.kanban |
Unknown/reserved frontmatter keys interleaved with schema-owned ones at board, lane, and card level — document.unknownFields must preserve exactly the order they were written in. |
coercion.kanban |
Lenient-field coercion and fallback: wrong-type scalars that coerce (title: 2048, iconColor: 42, background: 12345, width: "3") versus ones with no sensible reading that fall back to the default (title: [a, b], background: {x: 1}, width: 1.5), plus a deleted with an unusable timestamp that still tombstones. |
duplicate-top-level-keys.kanban |
A top-level key written twice — at board, lane (the strict order field), and card level. Last occurrence wins; not a fail-fast case (settled, newer than the original card text). Round-tripped to prove the earlier occurrence survives on disk, invisible only to reads. |
board-level-deleted.kanban |
A board-level deleted: key — legal per the frontmatter table but meaningless; ignored + warned, rest of the board loads normally. |
optional-keys.kanban |
order and schema optional below the board root (re-ruled 2026-07-31). One lane holds a ranked card plus every order-less shape — no key, an explicit null, order: banana, order: .nan — which all read as append-at-end in folder-name order; the strip holds a ranked lane, a schema-less one, and an order-less one. Also the golden case for the minimum agent card: a card whose whole frontmatter is a title. |
Malformed/ — one board per fail-fast case
Each board is minimal: one broken thing.
| Board | Case |
|---|---|
unparseable-yaml.kanban |
An unterminated flow sequence in the board's frontmatter. |
missing-schema.kanban |
Board root index.md has no schema key — the root only; below it a missing schema reads as 1 (Valid/optional-keys.kanban). |
schema-newer-than-app.kanban |
Board root schema: 2, newer than BoardLoader.supportedSchema. |
board-root-missing-index.kanban |
The board root folder itself has no index.md. |
The four order boards that used to live here — missing-order-lane, missing-order-card, explicit-null-order, non-numeric-order — were retired on 2026-07-31, when order became optional below the board root. Their shapes all live on in Valid/optional-keys.kanban as coercion cases.